Initialize the DISCO checkpoint from the time value - #4069
Merged
ChrisRackauckas merged 1 commit intoJul 29, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
5 tasks
Member
Author
|
Early CI dependency checkpoint: the Julia 1.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
disco_checkpointwithzero(t)instead ofzero(tType)solve!Root cause
The DISCO optimization added
disco_checkpoint = zero(tType). DynamicQuantities deliberately rejectszero(::Type{<:Quantity})when dimensions are runtime data, so ODE initialization failed before the first step. The initial time value already carries those dimensions, andzero(t)produces the correctly typed additive identity.A controlled parent/child test with an otherwise identical dependency graph passed 4/4 at
c538565b25and failed during initialization at408a7a30fe0;git bisectidentifies408a7a30fe0(disco optimizations) as the first bad commit. The failure is present with DynamicQuantities 1.12.2 and 1.13.0, so it is not a 1.13-only behavior change.CI prerequisite
#4066 is the current resolver prerequisite for testing this branch against registry SciMLBase 3.39.1. The code change itself is independent; the official Downstream validation below used a test-only stack of #4066 plus this commit.
Validation
GROUP=Downstreamon Restore SciMLBase 3.39 compatibility for owner imports #4066 + this commit: Time derivative 202/202, DynamicQuantities + Measurements 6/6,Pkg.testpassed in 1879.4 secondsgit diff --checkpasses